IR: Fix get_pragma_params for multiline pragmas
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/313/index.html |
mlange05
force-pushed
the
naml-fix-pragma-params-multiline
branch
from
9510d06 to
00abd4c
Compare
The associated test also checks the associated use of `fgen`, which triggered this problem in the first place.
reuterbal
force-pushed
the
naml-fix-pragma-params-multiline
branch
2 times, most recently
from
8486c69 to
ddb3e0d
Compare
reuterbal
approved these changes
May 10, 2024
reuterbal
added
the
ready for merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 165 165
Lines 35065 35079 +14
=======================================
+ Hits 33351 33365 +14
Misses 1714 1714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of
parse_exprfor reading pragma parameters does not account for multi-line pragmas with&linebreaks. This PR fixes this and adds a small test for this.I've also piggy-backed a small fix to loki-transform.py, where the recent introduction of
RemoveCodeTransformationwas not told to keepDR_HOOKcalls in the drivers via thekernel_onlyoption. With these two changes, EC-physics regression should be fine again.