Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out globals in get_local_arrays #370

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

awnawab
Copy link
Contributor

@awnawab awnawab commented Aug 30, 2024

A small PR to filter out global variables from get_local_arrays; these may be included if get_local_arrays is applied to routine.spec.

@awnawab awnawab requested review from mlange05 and reuterbal August 30, 2024 14:08
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/370/index.html

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (1f87624) to head (4b68863).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         178      178           
  Lines       37267    37271    +4     
=======================================
+ Hits        35555    35559    +4     
  Misses       1712     1712           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch! Implementation looks straightforward to me and is well tested.

@reuterbal reuterbal added the ready to merge This PR has been approved and is ready to be merged label Aug 30, 2024
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me. GTG :shipit:

@reuterbal reuterbal merged commit 5cab9bf into main Sep 2, 2024
13 checks passed
@reuterbal reuterbal deleted the naan-get-local-arrays branch September 2, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants