IR: Move expr_visitors to loki.ir
#372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlange05
force-pushed
the
naml-ir-expr-visitor
branch
from
ec49adc to
c56773d
Compare
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/372/index.html |
mlange05
force-pushed
the
naml-ir-expr-visitor
branch
from
c56773d to
cf9f4b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 95.48% 95.48% -0.01%
==========================================
Files 185 185
Lines 38651 38646 -5
==========================================
- Hits 36907 36901 -6
- Misses 1744 1745 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
force-pushed
the
naml-ir-expr-visitor
branch
from
cf9f4b3 to
a1d3bdf
Compare
mlange05
force-pushed
the
naml-ir-expr-visitor
branch
from
a1d3bdf to
189ce63
Compare
reuterbal
approved these changes
Oct 4, 2024
reuterbal
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing for now...Note: This sits on top of #366, because it moves the new tests alongside it.
Another refactoring change that moves the definition of various IR visitors (
expr_visitors.py) to theloki.irpackage. This means that now, at least in principle, we only have a one-way dependency betweenloki.ir=>loki.expression- and where this is broken, it is marked as such via local imports with pylint markers.Integration note: I'll leave this as draft until #366 is merged, so that the diff is not too overwhelming.