-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpilation: optional arguments #385
Conversation
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/385/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 95.48% 95.49% +0.01%
==========================================
Files 185 185
Lines 38646 38744 +98
==========================================
+ Hits 36902 37000 +98
Misses 1744 1744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat! A few minor nitpicks but otherwise good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, looks great! I'll do a rebase and merge once green
…all optional arguments are available, for cppgen and derivates properly handle optional arguments)
76b5b51
to
3e6e7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Looks great, GTG.
Allow/handle optional arguments for c-like-backends.
For
cgen
- assume all optional arguments are passed (inherently unsafe, thus warn)cppgen
(and all backends derived from that) - proper handling via optional argument with default valuenullptr
Moreover, introduced capabilities to jit compile C++ files (in addition to C files).