Remove duplicate declarations for external statements (fix #57) #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortran's external-stmt allows to declare procedure symbols as external separate to their return type declaration. That makes it virtually impossible to determine that this return type declaration refers to a procedure rather than a local variable until the corresponding
EXTERNAL
statement has been encountered.Because Fortran allows to represent this also as an attribute in the same declaration, we chose to represent this in Loki as external procedures in all cases. This means, we are replacing
by the equivalent representation
The frontends already translated external statements to the procedure declaration with the
EXTERNAL
attribute but also left the original variable declaration in place, thus triggering the problem reported in #57.In this PR, this behaviour is fixed via a sanitzation processing step that drops relevant symbols from the variable declarations.