Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for J306 GM tube #457

Closed
wants to merge 3 commits into from
Closed

Add support for J306 GM tube #457

wants to merge 3 commits into from

Conversation

rexfue
Copy link
Collaborator

@rexfue rexfue commented May 16, 2022

Added tube J306 to tube table

ThomasWaldmann
ThomasWaldmann requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit is unclean, has unrelated files, please remove.

@ThomasWaldmann
Copy link
Contributor

Also there is a strange build issue:

/home/runner/.platformio/packages/toolchain-xtensa-esp32/bin/../lib/gcc/xtensa-esp32-elf/8.4.0/../../../../xtensa-esp32-elf/bin/ld: /home/runner/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32/lib/libpp.a(hal_mac.o): in function `hal_init':
[542](https://github.com/ecocurious2/MultiGeiger/runs/6453096298?check_suite_focus=true#step:5:542)
(.text.hal_init+0xb4): multiple definition of `hal_init'; .pio/build/geiger/lib7fc/libMCCI LoRaWAN LMIC library.a(hal.cpp.o):/home/runner/work/MultiGeiger/MultiGeiger/.pio/libdeps/geiger/MCCI LoRaWAN LMIC library/src/hal/hal.cpp:416: first defined here
[543](https://github.com/ecocurious2/MultiGeiger/runs/6453096298?check_suite_focus=true#step:5:543)
collect2: error: ld returned 1 exit status
[544](https://github.com/ecocurious2/MultiGeiger/runs/6453096298?check_suite_focus=true#step:5:544)
*** [.pio/build/geiger/firmware.elf] Error 1

@ThomasWaldmann ThomasWaldmann changed the title New tube Add support for J306 GM tube May 16, 2022
@rexfue
Copy link
Collaborator Author

rexfue commented May 16, 2022

Closed PR because of problems

@rexfue rexfue closed this May 16, 2022
@rexfue rexfue deleted the new_tube branch May 16, 2022 14:42
@ThomasWaldmann
Copy link
Contributor

kizniche/ttgo-tbeam-ttn-tracker#45 maybe try this.

@ThomasWaldmann
Copy link
Contributor

or this lnlp/LMIC-node#41 .

@rexfue
Copy link
Collaborator Author

rexfue commented May 16, 2022

OK, I'll try this tomorrow an do a new PR

@t-pi
Copy link
Contributor

t-pi commented May 18, 2022

just added a separate PR to fix hal_init error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasWaldmann ThomasWaldmann ThomasWaldmann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexfue @ThomasWaldmann @t-pi