Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mastercard.svg file #874

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

ohmschrodinger
Copy link
Contributor

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • You have read the contributing guidelines
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.

#873

@edent
Copy link
Owner

edent commented Oct 28, 2024

I think you can make this even smaller. Take a look at the Flickr example for some ideas.

@ohmschrodinger
Copy link
Contributor Author

im not able to make the 2 semicircles in orange color
heres the updated code

<svg xmlns="http://www.w3.org/2000/svg"
aria-label="mastercard" role="img"
viewBox="0 0 512 512">
  <path d="M0 0h512v512H0" fill="#fff"/>
  <circle cx="180" cy="256" fill="#EB001B" r="120"/>
  <circle cx="332" cy="256" fill="#F79E1B" r="120"/>
    <path d="M310 161.8H202.7v189.4h107.5V161.8h-.2Z" fill="#FF5A00"/>
</svg>

can you help me out?

@edent
Copy link
Owner

edent commented Oct 28, 2024

@ohmschrodinger
Copy link
Contributor Author

DONE THANKS!!!!
lemme commit the changes

@edent
Copy link
Owner

edent commented Oct 29, 2024

Excellent! Now run it through a minifier like https://svgomg.net/ to see if you can make it even smaller :-)

@ohmschrodinger
Copy link
Contributor Author

Done!!!

@edent
Copy link
Owner

edent commented Oct 29, 2024

Nice one! Can you do Amex and Visa next??

@edent edent merged commit 930854e into edent:master Oct 29, 2024
1 check passed
@ohmschrodinger
Copy link
Contributor Author

Sure! lemme try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants