Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: manage CoreDNS addon as Helm chart #3388

Merged
merged 2 commits into from
Oct 7, 2024
Merged

helm: manage CoreDNS addon as Helm chart #3388

merged 2 commits into from
Oct 7, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Oct 4, 2024

Context

We're still in the process of moving CoreDNS from cluster addon to Helm chart. Prior art:

  1. helm: manage CoreDNS addon as Helm chart #3236 introduced the Helm chart
  2. helm: fix kubeadm bugs caused by CoreDNS installation #3353 fixed some bugs
  3. helm: revert parts of CoreDNS Helm chart packaging #3366 reverted everything except upgrade-agent support

Now that we released 2.18, we can reapply the changes.

Proposed change(s)

  • Reapply the reverted changes.

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the breaking change Change breaks existing API or configuration. label Oct 4, 2024
@burgerdev burgerdev added this to the v2.19.0 milestone Oct 4, 2024
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit e5d599d
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67018f6263b87e0008d0f73d

Copy link
Contributor

github-actions bot commented Oct 5, 2024

Coverage report

Package Old New Trend
bootstrapper/internal/kubernetes 37.70% 37.60% ↘️
bootstrapper/internal/kubernetes/k8sapi 11.80% 11.80% 🚧
cli/internal/cmd 41.10% 41.10% 🚧
internal/constellation 18.60% 18.50% ↘️
internal/constellation/helm 33.60% 34.50% ↗️
internal/constellation/helm/corednsgen 0.00% 0.00% 🆕
internal/kubernetes/kubectl 6.90% 8.20% ↗️
terraform-provider-constellation/internal/provider 3.50% 3.50% 🚧

@burgerdev burgerdev merged commit dd1763a into main Oct 7, 2024
12 checks passed
@burgerdev burgerdev deleted the burgerdev/coredns branch October 7, 2024 08:51
@msanft msanft removed the breaking change Change breaks existing API or configuration. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants