GitHub login method for auth #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereolog
previously approved these changes
Sep 9, 2024
przemekgradzki
requested changes
Sep 12, 2024
general/pages/connect/github.vue
Outdated
| statusMessage.value = 'Authentication failed. Redirecting...'; | ||
| toastStore.addToast(`GitHub authentication failed!`, 'error'); | ||
| authStore.clear(); | ||
| setTimeout(() => router.push('/'), 2000); |
There was a problem hiding this comment.
After a failed login, the user should return to the initial page instead of the /
mereolog
approved these changes
Sep 13, 2024
przemekgradzki
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now
Login with Githubbutton in the Login modal.GitHub Login Flow:
/ontologyName/connect/github/ontologyName/ontology