Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18 compatibility #1693

Merged
merged 12 commits into from
Oct 27, 2023
Merged

React 18 compatibility #1693

merged 12 commits into from
Oct 27, 2023

Conversation

danielweck
Copy link
Member

This PR works, as far as I can tell without noticeable regressions.
However, I propose that we do not merge into the develop branch / mainstream releases, because this would force Thorium forks to adapt strict TypeScript typing updates, and it may in fact also invalidate the use of legacy React 16-17 lib dependencies. I would rather encourage forks to upgrade to the latest official Git revision of Thorium, than discourage them to upgrade because of our eagerness to track React's latest updates (which are know to break parts of the ecosystem ... but thankfully without negative side effects as far as I know in Thorium).

@danielweck danielweck marked this pull request as draft May 26, 2022 13:15
@panaC
Copy link
Member

panaC commented Sep 19, 2023

Finally duplicated with my PR #1999

@danielweck danielweck mentioned this pull request Sep 22, 2023
@danielweck
Copy link
Member Author

danielweck commented Oct 27, 2023

The magnitude of changes in the ongoing GUI pull requests (see attached screenshot below) is prompting me to revisit the impact of breaking changes from this React 18 PR. I now think that the timing is right to introduce the move away from React 17. This will have repercussions (possibly negative) in Thorium forks, but not nearly as much as some of the GUI refactorings in the pending PRs, so I think we should schedule the React 18 evolution for the next version of Thorium, alongside all the GUI improvements (design, and implementation).

@danielweck
Copy link
Member Author

Screenshot 2023-10-27 at 10 37 08

@socket-security
Copy link

socket-security bot commented Oct 27, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/use-sync-external-store 0.0.5 None +0 3.29 kB types
@types/remote-redux-devtools 0.5.5...0.5.7 None +1/-1 254 kB types
@types/mime-types 2.1.1...2.1.3 None +0/-0 3.38 kB types
@types/debounce 1.2.1...1.2.3 None +0/-0 3.22 kB types
r2-shared-js 1.0.69...1.0.70 None +2/-2 5.63 MB danielweck
@types/yauzl 2.10.0...2.10.2 None +2/-1 3.88 MB types
rimraf 5.0.1...5.0.5 environment +4/-4 1.93 MB isaacs
@types/commonmark 0.27.6...0.27.8 None +0/-0 9.62 kB types
jest 29.6.2...29.7.0 None +89/-88 16.2 MB simenb
@types/tmp 0.2.3...0.2.5 None +0/-0 10.4 kB types
lunr-languages 1.12.0...1.14.0 None +0/-0 2.21 MB mihaivalentin
@types/dompurify 3.0.2...3.0.4 None +1/-1 17 kB types
electron-builder 24.6.3...24.6.4 None +14/-13 7.78 MB onegoldfishh
@types/jsdom 21.1.1...21.1.4 None +3/-2 3.91 MB types
glob 10.3.3...10.3.10 None +3/-3 1.66 MB isaacs
@types/urijs 1.19.19...1.19.22 None +0/-0 15.6 kB types
@types/uuid 9.0.2...9.0.6 None +0/-0 6.65 kB types
react-router-dom 6.14.2...6.17.0 None +5/-5 8.7 MB mjackson
@types/lunr 2.3.4...2.3.6 None +0/-0 40.8 kB types
react-router 6.14.2...6.17.0 None +2/-2 3.3 MB mjackson
@types/react-table 7.7.14...7.7.17 None +3/-3 411 kB types
@types/yazl 2.4.2...2.4.4 None +2/-1 3.88 MB types
@types/ramda 0.29.3...0.29.7 None +1/-1 281 kB types
@types/yargs 17.0.24...17.0.29 None +1/-1 69.1 kB types
@types/react-dom 17.0.20...18.2.14 None +3/-3 410 kB types
nanoid 4.0.2...5.0.2 None +0/-0 10.9 kB ai
@types/validator 13.11.1...13.11.5 None +0/-0 69.9 kB types
postcss 8.4.27...8.4.31 None +0/-0 197 kB ai
@types/xmldom 0.1.31...0.1.33 None +0/-0 4.8 kB types
@types/react 17.0.64...18.2.33 None +2/-2 378 kB types
react-redux 7.2.9...8.1.3 None +10/-8 5.92 MB acemarke
@typescript-eslint/eslint-plugin 6.3.0...6.9.0 None +22/-22 6.55 MB jameshenry
@typescript-eslint/parser 6.3.0...6.9.0 None +17/-16 3.66 MB jameshenry
react-focus-lock 2.9.5...2.9.6 None +7/-7 1.26 MB kashey
@types/jest 29.5.3...29.5.6 None +22/-22 4.6 MB types
@types/node 18.17.4...18.18.7 None +1/-0 3.87 MB types
@octokit/rest 20.0.1...20.0.2 None +8/-9 5.13 MB octokitbot
eslint-plugin-local-rules 1.3.2...2.0.0 None +0/-0 9.99 kB cletusw
react 17.0.2...18.2.0 None +0/-0 316 kB gnoff
eslint-plugin-react 7.33.1...7.33.2 None +58/-40 6.01 MB ljharb
@vanilla-extract/css 1.12.0...1.13.0 None +1/-1 571 kB vanilla-extract-css
react-dom 17.0.2...18.2.0 None +2/-2 4.91 MB gnoff
fork-ts-checker-webpack-plugin 8.0.0...9.0.0 None +19/-20 7.87 MB piotr-oles
@rollup/plugin-terser 0.4.3...0.4.4 None +4/-5 968 kB lukastaegert
inversify 6.0.1...6.0.2 None +0/-0 1.52 MB jameskmonger
uuid 9.0.0...9.0.1 None +0/-0 123 kB ctavan
@vanilla-extract/webpack-plugin 2.2.0...2.3.1 None +38/-38 18.8 MB vanilla-extract-css
electron 25.5.0...27.0.2 None +14/-12 5.02 MB electron-nightly
ts-loader 9.4.4...9.5.0 network +14/-14 7.85 MB johnnyreilly
concurrently 8.2.0...8.2.2 None +2/-2 453 kB gustavohenke
ts-unused-exports 10.0.0...10.0.1 None +0/-1 139 kB ts-unused-exports-user
stylelint 15.10.2...15.11.0 None +20/-18 1.82 MB mattxwang
dompurify 3.0.5...3.0.6 None +0/-0 724 kB cure53
typed-css-modules 0.7.2...0.8.0 None +7/-16 2.19 MB quramy
eslint-plugin-prettier 5.0.0...5.0.1 None +16/-15 2.33 MB jounqin
i18next 23.4.4...23.6.0 None +1/-1 842 kB adrai
ramda 0.29.0...0.29.1 None +0/-0 1.17 MB kedashoe

🚮 Removed packages: @babel/[email protected], @electron/[email protected], @types/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

@danielweck danielweck changed the title [WIP] DO NOT MERGE !! React 18 compatibility React 18 compatibility Oct 27, 2023
@danielweck danielweck marked this pull request as ready for review October 27, 2023 15:32
@danielweck danielweck merged commit f8da522 into develop Oct 27, 2023
4 checks passed
@danielweck danielweck deleted the feature/react18 branch October 27, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants