-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 compatibility #1693
React 18 compatibility #1693
Conversation
Finally duplicated with my PR #1999 |
The magnitude of changes in the ongoing GUI pull requests (see attached screenshot below) is prompting me to revisit the impact of breaking changes from this React 18 PR. I now think that the timing is right to introduce the move away from React 17. This will have repercussions (possibly negative) in Thorium forks, but not nearly as much as some of the GUI refactorings in the pending PRs, so I think we should schedule the React 18 evolution for the next version of Thorium, alongside all the GUI improvements (design, and implementation). |
This PR works, as far as I can tell without noticeable regressions.
However, I propose that we do not merge into the
develop
branch / mainstream releases, because this would force Thorium forks to adapt strict TypeScript typing updates, and it may in fact also invalidate the use of legacy React 16-17 lib dependencies. I would rather encourage forks to upgrade to the latest official Git revision of Thorium, than discourage them to upgrade because of our eagerness to track React's latest updates (which are know to break parts of the ecosystem ... but thankfully without negative side effects as far as I know in Thorium).