[DEV] collection of useful react hooks #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
danielweck
reviewed
Sep 22, 2023
| React.useEffect(() => { | ||
| registerKeyboardListener(ListenForKeyUP, keyboardShortcut(keyboardShortcutState), callback); | ||
| return () => unregisterKeyboardListener(callback); | ||
| }, [keyboardShortcutState]); |
There was a problem hiding this comment.
I haven't tested this hook placeholder yet, but I think this will cause unnecessary renders due to the "state" object inside the dependency array being compared via reference identity. See keyboardShortcutsMatch() calls in componentDidUpdate() class component lifecycle.
I also don't see the ensureKeyboardListenerIsInstalled() call equivalent to the componentDidMount() class component lifecycle (React.useEffect() with empty dependency array)
@panaC did you test this hook, or is this work in progress? (the PR is marked as "[DEV]")
Thank you :)
|
What's the difference with #1997 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.