Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): remove untranslated title attribute from General settings tab #2651

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

naglis
Copy link
Contributor

@naglis naglis commented Nov 11, 2024

This value is not translated and is being displayed as the tooltip when hovering on any element in the "General" settings tab:

Screenshot displaying the tooltip with the untranslated word "General" while hovering on an element in the "General" settings tab while Thorium is set to use the Lithuanian language

As the other tabs do not have a title attribute, I've elected to remove it instead of introducing the title attribute to other tabs.

This value is not translated and is being displayed as the tooltip when
hovering on any element in the "General" settings tab.

As the other tabs do not have a `title` attribute, I've elected to
remove it instead of introducing the `title` attribute to other tabs.
@danielweck danielweck merged commit 323875f into edrlab:develop Nov 13, 2024
7 checks passed
@danielweck
Copy link
Member

Thank you for spotting this error and for submitting a Pull Request, much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants