Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tvm project init command #14

Merged
merged 2 commits into from
May 18, 2022
Merged

feat: add tvm project init command #14

merged 2 commits into from
May 18, 2022

Conversation

Alec4r
Copy link
Member

@Alec4r Alec4r commented May 17, 2022 •
edited
Loading

Descriptions

This PR is to add the functionality to create tutor virtualenvs by projects.

How to test

pip install git+https://github.com/eduNEXT/tvm.git@10_redesign_the_tvm_model
tvm install v12.2.0
tvm use v12.2.0
mkdir test && cd test
tvm project init
source .tvm/bin/activate
tutor --version
which tutor
tvmoff

Also, you should find the .tvm directory in your project folder.

NOTA:

Must have merged pr #11

@Alec4r Alec4r added the enhancement New feature or request label May 17, 2022
@Alec4r Alec4r self-assigned this May 17, 2022
@Alec4r Alec4r linked an issue May 17, 2022 that may be closed by this pull request
creates the new usage of version@project_name #12
Closed
@Alec4r Alec4r requested review from felipemontoya and MaferMazu and removed request for felipemontoya May 17, 2022 20:21
MaferMazu
MaferMazu reviewed May 18, 2022
View reviewed changes
tvm/cli.py Show resolved Hide resolved
black-redoc
black-redoc approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@black-redoc black-redoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine as well, but remind review @MaferMazu suggest about version_is_valid and validate_version

@Alec4r Alec4r merged commit dedab27 into main May 18, 2022
@Alec4r Alec4r deleted the 12-creates-the-new-usage-of-versionproject_name branch June 24, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaferMazu MaferMazu MaferMazu left review comments

@black-redoc black-redoc black-redoc approved these changes

@felipemontoya felipemontoya Awaiting requested review from felipemontoya

Assignees

@Alec4r Alec4r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

creates the new usage of version@project_name
3 participants
@Alec4r @black-redoc @MaferMazu