docs: update README with the new template and add links to docs DS-281 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaferMazu
requested review from
dcoa,
Alec4r,
danielsgz,
Henrrypg and
JuanDavidBuitrago
|
@wlvasquez If you have any chance, I would appreciate your review here 😊🙌 |
|
Hi Mafer: |
dcoa
previously approved these changes
Oct 14, 2022
|
Agree. It should not open a new window. Check settings for links to make
sure you deactivate open new window for internal topics. Thanks Diana.
On Thu, 13 Oct 2022 at 7:10 PM Diana Olarte ***@***.***> wrote:
***@***.**** approved this pull request.
I approved I only have a small recommendation (I'm not sure this could be
possible), I think is better if the internal documentation doesn't open a
new tab (external links are okay)
—
Reply to this email directly, view it on GitHub
<#57 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZDQG3PGI3UUWCT6LEDK2MTWDCQFZANCNFSM6AAAAAAREX4XYI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
[image: Logo] <https://www.edunext.co/>
www.edunext.co
[image: linkedin icon] <https://www.linkedin.com/company/edunext/>[image:
youtube icon] <https://www.youtube.com/user/edunextco>[image: instagram
icon] <https://www.instagram.com/edunext.co/>[image: facebook icon]
<https://www.facebook.com/eduNEXT-240053697964460>
Wanda Lipscomb-Vásquez
Knowledge Management Specialist
***@***.*** ***@***.***>
+573243928389
|
MaferMazu
force-pushed
the
mfmz/update-readme-and-doc
branch
from
9a1861d
to
3462718
Compare
|
Thank @dcoa and @wlvasquez for the advice; I agree. The PR is ready for your review again 😊 |
|
Perfect. Reviewed and approved. Thank you Mafer |
dcoa
approved these changes
Oct 14, 2022
JuanDavidBuitrago
approved these changes
Oct 14, 2022
MaferMazu
added a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the README documentation following this template and adds the correct links in the documentation.
How to test
To test the README, see https://github.com/eduNEXT/tvm/tree/mfmz/update-readme-and-doc
To test the links, go to https://edunext-docs-tvm--57.com.readthedocs.build/en/57/ and try links in the Related part of Topic Guides (Tutor Manager and Env manager); and check the Next Step of Quickstart and Tutorials>Creating Two Tutor Env