Update mailing list hashing mechanism

eduardoboucas · Nov 25, 2016 · 3d7c4ee · 3d7c4ee
1 parent 0ffa8f2
commit 3d7c4ee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/Staticman.js b/lib/Staticman.js
@@ -277,7 +277,7 @@ Staticman.prototype._initialiseSubscriptions = function () {
   })
 
   // Initialise SubscriptionsManager
-  const subscriptions = new SubscriptionsManager(this.github, mailgun)
+  const subscriptions = new SubscriptionsManager(this.parameters, this.github, mailgun)
 
   return subscriptions
 }
@@ -331,7 +331,7 @@ Staticman.prototype._validateConfig = function (config) {
   let missingFields = []
 
   // Checking for missing required fields
-  requiredFields.forEach((requiredField) => {
+  requiredFields.forEach(requiredField => {
     if (objectPath.get(config, requiredField) === undefined) {
       missingFields.push(requiredField)
     }

diff --git a/lib/SubscriptionsManager.js b/lib/SubscriptionsManager.js
@@ -1,14 +1,18 @@
 'use strict'
 
+const md5 = require('md5')
 const Notification = require('./Notification')
 
-const SubscriptionsManager = function (dataStore, mailAgent) {
+const SubscriptionsManager = function (parameters, dataStore, mailAgent) {
+  this.parameters = parameters
   this.dataStore = dataStore
   this.mailAgent = mailAgent
 }
 
 SubscriptionsManager.prototype._getListAddress = function (entryId) {
-  return `${entryId}@${this.mailAgent.domain}`
+  const compoundId = md5(`${this.parameters.username}-${this.parameters.repository}-${entryId}`)
+
+  return `${compoundId}@${this.mailAgent.domain}`
 }
 
 SubscriptionsManager.prototype._get = function (entryId) {