Add relative option parameter to businessDiff
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea about using an option parameter. I guess the default should be to keep the current behaviour, while the next major bump it could be switched. Could you implement it in your PR please? |
lyleunderwood
force-pushed
the
negative-diff
branch
from
fed3b3e to
f61a5a7
Compare
|
@mcdado added a |
lyleunderwood
force-pushed
the
negative-diff
branch
from
412f4d4 to
1573b05
Compare
|
Realized i had mistakenly removed a test that was still relevant, also squashed. |
|
As spoken in #32 this can be merged. LGTM. @lyleunderwood one thing though… in the README example you omitted the second parameter |
lyleunderwood
force-pushed
the
negative-diff
branch
from
1573b05 to
bd03b8e
Compare
|
@mcdado nice catch, fixed |
lyleunderwood
changed the title
relative option parameter to businessDiff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32.
This changes behavior of
businessDiff, and may break existing code which relies on current behavior. As this PR stands and according to semver, this may constitute a major version bump. Maybe this could instead be implemented under an alternate function name or as an option tobusinessDiffuntil a major version comes around?The goal here is to bring the behavior of
businessDiffin-line with the behavior of moment'sdiff, as specified here: