feat: Add manufacture_data django command #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnagro
approved these changes
Sep 13, 2023
robrap
reviewed
Sep 13, 2023
| [2.1.0] - 2023-06-01 | ||
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| * Adds test factory |
There was a problem hiding this comment.
Two high-level comments:
- This functionality seems low on docs about the new functionality (README or longer docstrings, etc.), including this changelog entry.
- I don't think this repo is the right place for this, but we should discuss. See https://github.com/edx/edx-arch-experiments/blob/main/docs/decisions/0001-purpose-of-this-repo.rst. I'm not sure that this aligns. That said, the missing docs makes it hard for me to be sure.
There was a problem hiding this comment.
I agree. I think this might make more sense in devstack
There was a problem hiding this comment.
I agree. I think this might make more sense in devstack
Do we have any history of the decision to use edx-django-utils that we can provide here or are on the new PR?
rgraber
reviewed
Sep 13, 2023
| @@ -0,0 +1,314 @@ | |||
| """ | |||
| Management command for making things with test factories | |||
There was a problem hiding this comment.
An example of how this might be called would be useful
|
@marlonkeating can I close this now that the work has been moved to django-utils? |
[inform] Here is a link to the PR with the new code: openedx/edx-django-utils#369 |
|
Closed due to work being moved to openedx/edx-django-utils#369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This change migrates the
manufacture_datadjango command introduced in openedx/edx-enterprise#1826 to where it can be used outside of the enterprise ecosystem.Merge checklist:
Check off if complete or not applicable:
Remaining Issues