feat: Log all span-starts for the first minute #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog Support has asked us to log all span-starts. I'm hoping that they can get what they need if we just log the first minute of spans, since the problem seems to be related to some of the first requests after deploy or restart. Excluding function-docstring linting for the span processor, since those are essentially overrides. (pylint only started caring once one of the methods was more than 4 lines long.)
dianakhuang
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog Support has asked us to log all span-starts. I'm hoping that they can get what they need if we just log the first minute of spans, since the problem seems to be related to some of the first requests after deploy or restart.
Excluding function-docstring linting for the span processor, since those are essentially overrides. (pylint only started caring once one of the methods was more than 4 lines long.)
Merge checklist:
Check off if complete or not applicable: