Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove early span-start logging; fix loading of Django settings #772

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

timmc-edx
Copy link
Member

I still don't understand why this setting loading was broken -- maybe there's something unusual about the way plugin apps are loaded?

This addresses #771

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

I still don't understand why this setting loading was broken -- maybe
there's something unusual about the way plugin apps are loaded?

This addresses #771
@timmc-edx timmc-edx merged commit 6be3a73 into main Aug 13, 2024
6 of 7 checks passed
@timmc-edx timmc-edx deleted the timmc/fix-span-start branch August 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants