Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring package is not usable on MacOS #15

Closed
matej-g opened this issue Sep 20, 2021 · 2 comments · Fixed by #16
Closed

monitoring package is not usable on MacOS #15

matej-g opened this issue Sep 20, 2021 · 2 comments · Fixed by #16

Comments

@matej-g
Copy link
Collaborator

matej-g commented Sep 20, 2021

See the report in thanos-io/thanos#4642.

The monitoring package uses github.com/containerd/cgroups, which seem to include code usable only on Linux platforms. We should find a way to make code from monitoring run on MacOS as well.
@bwplotka
Copy link
Contributor

👍🏽

@matej-g
Copy link
Collaborator Author

matej-g commented Oct 8, 2021

It seems to me this would not be a trivial fix, since the monitoring package depends on working with cgroups and using https://github.com/containerd/cgroups, which is not really available on MacOS.

Other option that comes to mind would be to not enable the option WithCurrentProcessAsContainer on MacOS (I think we only use cgroups package because of it) and make the compilation conditional on which system it is running on. This would allow usage of monitoring package on MacOS, just without the current container option.

@matej-g matej-g mentioned this issue Oct 8, 2021
Closed
2 tasks
@squat squat mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

monitoring: allow compilation for non-Linux squat/e2e
2 participants
@bwplotka @matej-g