-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Example: Do not use monitoring endpoint #4726
Interactive Example: Do not use monitoring endpoint #4726
Conversation
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
))))))))))))))))))))))))))))))))))))))))))): How hard is to fix e2emonitoring to support Mac? 🤔 |
I given it some more thought in efficientgo/e2e#15 (comment), but this would be the quickest and simplest way to unblock users for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM and I think I can run it locally on MAC now.
Another problem I got is related to
|
We actually won't need this PR anymore, the upstream issue has been fixed - efficientgo/e2e#15 I will open a new PR, now we just need to bump the version. As for the |
Closing this in favor of #4779, please take a look! |
Signed-off-by: Matej Gera [email protected]
Changes
See #4642 - the interactive test cannot run on MacOS due to upstream issue (usage of package available only for Linux platform). This is only due to usage of
e2emonitoring
package, which is however not necessary for running the interactive example. In order to make the example accessible to more users, I'd suggest to remove the monitoring endpoint for now.Verification
Waiting on final verification from an Apple user 😅