Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new URL instead of url.parse #4048

Merged
merged 2 commits into from
Nov 15, 2019
Merged

fix: use new URL instead of url.parse #4048

merged 2 commits into from
Nov 15, 2019

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@Jeff-Tian
Copy link
Contributor

@dead-horse
Copy link
Member Author

if (now - record.timestamp >= this.dnsCacheLookupInterval) {

有过期时间

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #4048 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4048   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          34      34           
  Lines         947     954    +7     
======================================
+ Hits          947     954    +7
Impacted Files Coverage Δ
lib/core/dnscache_httpclient.js 100% <100%> (ø) ⬆️
lib/core/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afed910...e08879f. Read the comment docs.

@dead-horse dead-horse merged commit b7718c1 into master Nov 15, 2019
@dead-horse dead-horse deleted the remove-urlparse branch November 15, 2019 05:12
popomore pushed a commit that referenced this pull request Nov 15, 2019
fix: use new URL instead of url.parse (#4048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants