-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds TypeScript declarations #2
Conversation
@egoist I added prop types, pls check |
Could you please merge this? |
Would be great to have! Edit: I can confirm that this works. |
Unsure if this is still up-to-date but came to this repo explicitly looking for typings for this package, would really be great to see this merged. |
Same |
types/index.d.ts
Outdated
import { FunctionalComponentOptions } from 'vue'; | ||
const _default: FunctionalComponentOptions<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { FunctionalComponentOptions } from 'vue'; | |
const _default: FunctionalComponentOptions<{ | |
import { FunctionalComponent } from 'vue'; | |
const _default: FunctionalComponent<{ |
types/index.d.ts
Outdated
code: string; | ||
language: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: string; | |
language: string; | |
code?: string; | |
language?: string; |
If this PR is only missing the changes suggested, can @vatson make them so we can merge? I could also fork @vatson repo, do the changes, and create a new PR. |
This closes #39 |
@vatson What's the status of this? Why just closed? |
First, the PR has been stuck for 3 years. I don't see any interest and activity from the maintainer side. All of this tells me that this issue will be here forever. Second, current I could do typings for both vue 2 and vue 3 with new PRs, but still I'm not sure if the project maintainers are ready to assist and support. It looks like a waste of time to me. |
@vatson In such a case, did you consider https://github.com/DefinitelyTyped/DefinitelyTyped ? |
Recently, TS is becoming more popular. It would be great if you allow to add support for TypeScript.