Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Listener.ts #1342

Conversation

ashish-egov
Copy link
Collaborator

@ashish-egov ashish-egov commented Jan 17, 2025

Summary by CodeRabbit

  • Improvements
    • Enhanced Kafka message listener to support asynchronous processing of campaign-related operations
    • Improved error handling and logging for message processing functions

@ashish-egov
Copy link
Collaborator Author

@coderabbitai review

@ashish-egov ashish-egov merged commit c04fdc2 into HCMPRE-1788-project-creation-entity-persistence Jan 17, 2025
2 of 4 checks passed
@ashish-egov ashish-egov deleted the ashish-egov-patch-4 branch January 17, 2025 07:54
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve updating the Kafka listener in the project factory to use asynchronous message handling. The modifications make the functions handleCampaignMapping, handleCampaignProcessing, and handleCampaignSubProcessing awaitable, which means these functions now return promises. This change ensures that the listener waits for the complete execution of these operations before moving to the next message, potentially improving the reliability of message processing.

Changes

File Change Summary
health-services/project-factory/src/server/kafka/Listener.ts Added await to three message handling functions: handleCampaignMapping, handleCampaignProcessing, and handleCampaignSubProcessing

Sequence Diagram

sequenceDiagram
    participant Listener
    participant CampaignMapping
    participant CampaignProcessing
    participant CampaignSubProcessing

    Listener->>CampaignMapping: await handleCampaignMapping
    CampaignMapping-->>Listener: Promise resolved
    Listener->>CampaignProcessing: await handleCampaignProcessing
    CampaignProcessing-->>Listener: Promise resolved
    Listener->>CampaignSubProcessing: await handleCampaignSubProcessing
    CampaignSubProcessing-->>Listener: Promise resolved
Loading

Suggested reviewers

  • jagankumar-egov

Poem

🐰 Async rabbits hop and wait,
Kafka messages now seal their fate,
Promises resolved with care,
No message left hanging in the air,
Await the flow, let processing shine bright! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7ab7bc and e20bcfe.

📒 Files selected for processing (1)
  • health-services/project-factory/src/server/kafka/Listener.ts (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant