Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGraph minimization with bisimulation #346

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

EGraph minimization with bisimulation #346

wants to merge 22 commits into from

Conversation

danieltherealyang
Copy link

Implemented bisimulation to convert egraph to dtfa, minimize the dtfa, then convert the dtfa back to egraph. There is quite a bit of overhead but the code is all self contained. If someone wants to try optimizing the minimization code they can do that too.

@danieltherealyang
quicksave
992b3e9
@danieltherealyang
implemented splitfn data structures for hashing
ebb9eec
@danieltherealyang
dtfa completed, need to bug test
94eb2e7
@danieltherealyang
bugfix: add coarse_id to compound_blocks when inserting new fine_id t…
d04b035 
…o coarse bloc
@danieltherealyang
Added some comments
5ea808f
@danieltherealyang
generate_obsmap works
35a0217
@danieltherealyang
fixed choose_smaller_half bug
9029c34
@danieltherealyang
tested obs_q in new
a1ae404
@danieltherealyang
separated obsmap changes from splitfn for clarity
d4326a4
@danieltherealyang
manual testing for splitf/splitfn, everything seems to be working
0c3182c
@danieltherealyang
created DtfaMapper which can map any generic state and symbol classes
2063e42
@danieltherealyang
Outline for minimize egraph complete
57c9a32
@danieltherealyang
Egraph minimize helper fns implementation done, needs testing
20551d3
@danieltherealyang
Changed dtfa testcase from DTFA::fn() to Dtfa::fn().
dfe3f60
@danieltherealyang
Transition table returns empty iterator if no rules for state.
ed6a306
@danieltherealyang
Fixed inconsistent symbols between egraph.nodes and egraph.classes().…
7038594 
…flatten_map()
@danieltherealyang
Merge branch 'main' of https://github.com/egraphs-good/egg into clean
ce29226
@danieltherealyang
changed dtfa test to not fail
1a8b1a8
@danieltherealyang
remove hashbrown import and cargo fmt fix
38c036b
@danieltherealyang
clippy fixes
c28ba0d
@danieltherealyang
more clippy fixes
52322d6
@danieltherealyang
Fix cargo fmt
e6453c0
@oflatt
Copy link
Member

oflatt commented Jan 23, 2025

Very cool
I don't know if you've seen this repo: https://github.com/egraphs-good/egraph-serialize
It has a bunch of egraphs you could try your algorithm on, and see if you can improve the extraction results or performance

@oflatt
Copy link
Member

oflatt commented Jan 23, 2025

However, I'm guessing that we won't want to merge and maintain this algorithm in egg itself. You may have more luck adding it to the extraction gym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieltherealyang @oflatt