Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm: use npm_config_prefix instead of NPM_CONFIG_PREFIX #100

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

vincentbernat
Copy link
Contributor

Recent versions of npm (at least 1.4.21) don't accept
NPM_CONFIG_PREFIX being valid. They expect the lower-case version
instead. Since I don't know for sure that older versions also accept
that, I keep both of them.

Recent versions of npm (at least 1.4.21) don't accept
NPM_CONFIG_PREFIX being valid. They expect the lower-case version
instead. Since I don't know for sure that older versions also accept
that, I keep both of them.
@ekalinin
Copy link
Owner

Hi @vincentbernat, thanks for report & hotfix!
But can you provide more details about error?

I just checked and didn't get any errors:

➥ virtualenv env
➥ . env/bin/activate
(env) ➥ pip install nodeenv
(env) ➥ nodeenv --version
0.11.0
(env) ➥ nodeenv -p --prebuilt
(env) ➥ npm -v
1.4.23
(env) ➥ npm install -g sitemap
[email protected] ~/tmp/env/lib/node_modules/sitemap
(env) ➥ npm install typogr
[email protected] node_modules/typogr
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected])

@vincentbernat
Copy link
Contributor Author

❦ 20 août 2014 14:30 -0700, Eugene Kalinin [email protected] :

Hi @vincentbernat, thanks for report & hotfix!
But can you provide more details about error?

I just checked and didn't get any errors:

Maybe this has been fixed later?

When I do "npm -g prefix", I get /usr/local, but with "env
npm_config_prefix=/something npm -g prefix", I get /something. What do
you get? I don't have the bandwidth currently to use anything else than

"nodeenv -p -n system", so I end up with npm 1.4.21.

printk("Entering UltraSMPenguin Mode...\n");
2.2.16 /usr/src/linux/arch/sparc64/kernel/smp.c

ekalinin added a commit that referenced this pull request Sep 4, 2014
npm: use npm_config_prefix instead of NPM_CONFIG_PREFIX
@ekalinin ekalinin merged commit 7f17fa1 into ekalinin:master Sep 4, 2014
@ekalinin
Copy link
Owner

ekalinin commented Sep 4, 2014

Thanks for patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants