Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, test Python 3.10, and run on tests on GitHub Actions #298

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

adamchainz
Copy link
Contributor

Several commits, happy to split if appropriate.

  1. Fix warning on Pytest

Fix:

tests/nodeenv_test.py:49
  /home/runner/work/nodeenv/nodeenv/tests/nodeenv_test.py:49: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
  Use @pytest.fixture instead; they are the same.
    @pytest.yield_fixture
  1. Fix Flake8 error

Fix this error:

nodeenv.py:359:80: E501 line too long (84 > 79 characters)

Added in 8e1c574

  1. Update argument parser usage in tests

Missed in 8e1c574.

  1. Drop Python 3.6, add Python 3.10, run tests on GitHub Actions

Travis no longer posts results over to GitHub. I think this is how the previous failures went unseen. This commit removes the Travis config and adds a GitHub Actions one based on a recipe I use in my projects. This includes a method of combining Coverage results on GitHub Actions as per this blog post, removing the need for coveralls.

I removed Python 3.6, which is EOL, and added tests for Python 3.8 through 3.10. I didn’t remove 2.7 but would be happy to do so - it’s 2 years past its EOL.

I dropped the PyPy test run because the module is pure Python. I don’t think it’s worth the effort trying to test every library in existence with PyPy.

Fix:

```
tests/nodeenv_test.py:49
  /home/runner/work/nodeenv/nodeenv/tests/nodeenv_test.py:49: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
  Use @pytest.fixture instead; they are the same.
    @pytest.yield_fixture
```
Fix this error:

```
nodeenv.py:359:80: E501 line too long (84 > 79 characters)
```

Added in 8e1c574
@adamchainz
Copy link
Contributor Author

The test run needs approving on GitHub Actions. You can see a successful run on my fork’s actions tab: https://github.com/adamchainz/nodeenv/actions/runs/1659055175

@ekalinin ekalinin merged commit 11b7134 into ekalinin:master Jan 5, 2022
@ekalinin
Copy link
Owner

ekalinin commented Jan 5, 2022

I didn’t remove 2.7 but would be happy to do so - it’s 2 years past its EOL.

Yeah, I understand. But they're a lot of projects still on py2.7. So, let's save 2.7 support for a while.

Thank you! Great patch!

@adamchainz adamchainz deleted the python_3.10 branch January 5, 2022 20:14
@adamchainz
Copy link
Contributor Author

Great, thank you for fast review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants