Migrate to golangci-lint

[sayboras]

Description

Migrate from gometalinter to golangci-lint as mentioned in #973

Currently, I keep the same configuration as gometalinter (govet, golint, errcheck, deadcode, missspel). gofmt, unused, goimports linters are added. The goal is to migrate to golangci-lint with minimal code changes.

Any improvement can be tackled based on discussion.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, and examples directory)
• Manually tested

[errordeveloper]

Thanks @sayboras! I'd like to merge #1200 first.

[sayboras]

@errordeveloper sure, I will rebase later

[martina-if]

Hi @sayboras , thank you so much for this PR! This is great! I added some feedback :)

[martina-if]

Hi @sayboras , thanks again for this PR. Since it introduces some risks in the build pipeline I would like to hold it until the end of kubecon next week. By the way if you happen to go come and say hi at the Weaveworks booth :)

[sayboras]

Hi @sayboras , thanks again for this PR. Since it introduces some risks in the build pipeline I would like to hold it until the end of kubecon next week. By the way if you happen to go come and say hi at the Weaveworks booth :)

No hurry, I can leave it as it is now :).

I wish I could have come for kube con 😢 , hopefully next year

[sayboras]

Let me know if you have any other comments, happy to address.

[martina-if]

Thank you for being so patient and keeping this up to date! :) We will try to merge it next week!

[martina-if]

@sayboras it seems I can't push to your branch. Can you run this command locally and push the changes? make -f Makefile.docker commit-new-image-tag. This is what we need to do when we change the tooling so that we use a new version of the docker image. I will push the docker image to the docker hub as well. That should make the circleci pipeline happy.

[sayboras]

@sayboras it seems I can't push to your branch. Can you run this command locally and push the changes? make -f Makefile.docker commit-new-image-tag. This is what we need to do when we change the tooling so that we use a new version of the docker image. I will push the docker image to the docker hub as well. That should make the circleci pipeline happy.

I tried to push the new image before, but got the below error

denied: requested access to the resource is denied
make: *** [push-build-image] Error 1

So it might need your help on this last step, I updated the manifest as well.

[martina-if]

I have now pushed the docker image with the tool installed so the build should not fail because of that.

If you check, there are some failures from the generated aws sdk mocks. We should probably make the linter ignore those.

[martina-if]

Why was this one changed?

[sayboras]

this lint is to check shadow declaration of variable. Lot of times we re-declare err by using := operator.

Let me know if you want to fix it, I can make the changes.

time "/Users/tammach/go/bin/golangci-lint" run
pkg/gitops/flux/installer.go:166:5         govet  shadow: declaration of "err" shadows declaration at line 133
pkg/gitops/flux/installer.go:172:6         govet  shadow: declaration of "err" shadows declaration at line 133
pkg/gitops/flux/installer.go:182:5         govet  shadow: declaration of "err" shadows declaration at line 133
pkg/gitops/profile.go:52:5                 govet  shadow: declaration of "err" shadows declaration at line 46
pkg/addons/vpc_controller.go:98:7          govet  shadow: declaration of "err" shadows declaration at line 87
pkg/nodebootstrap/userdata.go:104:5        govet  shadow: declaration of "err" shadows declaration at line 96
pkg/kubernetes/client.go:313:6             govet  shadow: declaration of "err" shadows declaration at line 308
pkg/kubernetes/client.go:357:6             govet  shadow: declaration of "err" shadows declaration at line 351
pkg/kubernetes/client.go:395:6             govet  shadow: declaration of "err" shadows declaration at line 351
pkg/eks/api.go:206:5                       govet  shadow: declaration of "err" shadows declaration at line 196
pkg/ctl/create/cluster.go:112:5            govet  shadow: declaration of "err" shadows declaration at line 94
pkg/ctl/create/cluster.go:116:5            govet  shadow: declaration of "err" shadows declaration at line 94
pkg/ctl/create/cluster.go:134:7            govet  shadow: declaration of "err" shadows declaration at line 94
pkg/ctl/create/cluster.go:375:7            govet  shadow: declaration of "err" shadows declaration at line 346
pkg/ctl/create/cluster.go:381:7            govet  shadow: declaration of "err" shadows declaration at line 346
pkg/ctl/create/cluster.go:384:7            govet  shadow: declaration of "err" shadows declaration at line 346
pkg/ctl/create/fargate.go:65:5             govet  shadow: declaration of "err" shadows declaration at line 61
pkg/ctl/create/fargate.go:69:9             govet  shadow: declaration of "err" shadows declaration at line 61
pkg/ctl/create/fargate.go:81:5             govet  shadow: declaration of "err" shadows declaration at line 61
pkg/ctl/create/iamidentitymapping.go:56:5  govet  shadow: declaration of "err" shadows declaration at line 51
pkg/ctl/create/iamidentitymapping.go:68:5  govet  shadow: declaration of "err" shadows declaration at line 51
pkg/ctl/create/iamidentitymapping.go:76:9  govet  shadow: declaration of "err" shadows declaration at line 51
pkg/ctl/create/iamserviceaccount.go:71:5   govet  shadow: declaration of "err" shadows declaration at line 65
pkg/ctl/create/iamserviceaccount.go:75:9   govet  shadow: declaration of "err" shadows declaration at line 65
pkg/ctl/create/nodegroup.go:86:5           govet  shadow: declaration of "err" shadows declaration at line 80
pkg/ctl/create/nodegroup.go:90:9           govet  shadow: declaration of "err" shadows declaration at line 80
pkg/ctl/create/nodegroup.go:94:5           govet  shadow: declaration of "err" shadows declaration at line 80
pkg/ctl/delete/cluster.go:92:5             govet  shadow: declaration of "err" shadows declaration at line 86
pkg/ctl/delete/cluster.go:97:5             govet  shadow: declaration of "err" shadows declaration at line 86
pkg/ctl/delete/cluster.go:101:9            govet  shadow: declaration of "err" shadows declaration at line 86
pkg/ctl/delete/fargate.go:58:5             govet  shadow: declaration of "err" shadows declaration at line 54
pkg/ctl/delete/iamidentitymapping.go:53:5  govet  shadow: declaration of "err" shadows declaration at line 47
pkg/ctl/delete/iamidentitymapping.go:64:9  govet  shadow: declaration of "err" shadows declaration at line 47
pkg/ctl/delete/iamidentitymapping.go:76:5  govet  shadow: declaration of "err" shadows declaration at line 47
pkg/ctl/delete/iamserviceaccount.go:71:5   govet  shadow: declaration of "err" shadows declaration at line 65
pkg/ctl/delete/nodegroup.go:62:5           govet  shadow: declaration of "err" shadows declaration at line 56
pkg/ctl/delete/nodegroup.go:66:9           govet  shadow: declaration of "err" shadows declaration at line 56
pkg/ctl/drain/nodegroup.go:58:5            govet  shadow: declaration of "err" shadows declaration at line 52
pkg/ctl/drain/nodegroup.go:62:9            govet  shadow: declaration of "err" shadows declaration at line 52
pkg/ctl/enable/profile.go:87:5             govet  shadow: declaration of "err" shadows declaration at line 83
pkg/ctl/enable/repo.go:54:5                govet  shadow: declaration of "err" shadows declaration at line 50
pkg/ctl/enable/utils.go:18:5               govet  shadow: declaration of "err" shadows declaration at line 14
pkg/ctl/get/fargate.go:64:5                govet  shadow: declaration of "err" shadows declaration at line 60
pkg/ctl/get/iamidentitymapping.go:57:5     govet  shadow: declaration of "err" shadows declaration at line 52
pkg/ctl/get/iamserviceaccount.go:63:5      govet  shadow: declaration of "err" shadows declaration at line 58
pkg/ctl/get/iamserviceaccount.go:67:9      govet  shadow: declaration of "err" shadows declaration at line 58
pkg/ctl/get/nodegroup.go:69:5              govet  shadow: declaration of "err" shadows declaration at line 64
pkg/ctl/scale/nodegroup.go:68:5            govet  shadow: declaration of "err" shadows declaration at line 63
pkg/ctl/update/cluster.go:63:5             govet  shadow: declaration of "err" shadows declaration at line 57
pkg/ctl/update/cluster.go:67:9             govet  shadow: declaration of "err" shadows declaration at line 57

[martina-if]

Right, I wonder how this was working before 🤔 If there is a way to only allow shadowing err and ctx that would be nice. Otherwise let's leave it like that for now.

[sayboras]

There is no way that I am aware of. I think i just leave it for now :(