Skip to content

Commit

Permalink
Send heartbeat after voting phase, fixes subtle synchronization bug
Browse files Browse the repository at this point in the history
  • Loading branch information
ekuiter committed Jun 10, 2019
1 parent 50bdacf commit 7fef130
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions client/src/store/reducer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ function serverReceiveReducer(state: State, action: Action): State {
let [kernelContext, kernelCombinedEffect] =
Kernel.run(state, collaborativeSession.artifactPath, kernel =>
kernel.resolveConflict(action.payload.versionID));
const artifactPath = collaborativeSession.artifactPath;
let heartbeat;
[kernelContext, heartbeat] = Kernel.run(state, artifactPath, kernel => kernel.generateHeartbeat());
enqueueMessage({type: MessageType.KERNEL, message: heartbeat}, artifactPath);
deferred(flushMessageQueue)();
return {
...collaborativeSession,
kernelContext,
Expand Down

0 comments on commit 7fef130

Please sign in to comment.