Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake changes #1048

Merged
merged 50 commits into from
Nov 17, 2024
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
cc64fe1
enable emscripten build with tbb enabled
pca006132 Nov 15, 2024
595b633
nix: fix emscripten build, add tbb build
pca006132 Nov 15, 2024
7032c4b
browser
pca006132 Nov 15, 2024
568ebbf
fix python build
pca006132 Nov 15, 2024
8e71a37
minor
pca006132 Nov 15, 2024
ae78dd1
no parallel sdf for js
pca006132 Nov 15, 2024
e5960b2
disable test for emscripten-tbb
pca006132 Nov 15, 2024
27204cd
Merge branch 'master' into emscripten-tbb
pca006132 Nov 16, 2024
162ca3c
add cache for nix python build
pca006132 Nov 16, 2024
b3bed73
cmake changes
pca006132 Nov 16, 2024
8a372bf
fix
pca006132 Nov 16, 2024
590fc5c
update
pca006132 Nov 16, 2024
b15c7b3
update
pca006132 Nov 16, 2024
fcf4e22
Merge remote-tracking branch 'upstream/emscripten-tbb' into cmake-ref…
pca006132 Nov 16, 2024
8788bff
update
pca006132 Nov 16, 2024
b880c7b
update
pca006132 Nov 16, 2024
deab097
move python dependency handling
pca006132 Nov 16, 2024
9d6892b
more changes
pca006132 Nov 16, 2024
4eca995
format
pca006132 Nov 16, 2024
ddfc19f
fix broken format
pca006132 Nov 16, 2024
f5dafa9
fix
pca006132 Nov 16, 2024
e553566
simplify
pca006132 Nov 16, 2024
fa62dc2
allow emscripten with cbind
pca006132 Nov 16, 2024
abc019e
build fetched dependencies as static libs
pca006132 Nov 16, 2024
58e8be8
fix static build
pca006132 Nov 16, 2024
0ca6a6a
fix rebuild
pca006132 Nov 16, 2024
5b6a9df
fix extras
pca006132 Nov 16, 2024
5bdd834
Merge remote-tracking branch 'upstream/master' into cmake-refactor
pca006132 Nov 16, 2024
d8e8c4f
remove parallel.h from public API
pca006132 Nov 16, 2024
f6616a0
update tests
pca006132 Nov 16, 2024
fdfdf73
make dependencies private
pca006132 Nov 16, 2024
c199560
move parallel.h
pca006132 Nov 16, 2024
1c9b86f
missing utils.h change
pca006132 Nov 16, 2024
385e89a
fix
pca006132 Nov 16, 2024
4143509
fix...
pca006132 Nov 17, 2024
7e0a9df
fix wasm tbb
pca006132 Nov 17, 2024
916c3b2
add more cmake consumer tests
pca006132 Nov 17, 2024
21ed208
fix consumer
pca006132 Nov 17, 2024
2e8a96c
add rpath
pca006132 Nov 17, 2024
f2fd36d
Revert "add rpath"
pca006132 Nov 17, 2024
14cc182
rpath specific to macos
pca006132 Nov 17, 2024
271b95b
use override
pca006132 Nov 17, 2024
4fdba84
forgot to set rpath...
pca006132 Nov 17, 2024
f02edbb
remove #1045 related changes
pca006132 Nov 17, 2024
253333c
integrate #1052
pca006132 Nov 17, 2024
73359da
allow version override
pca006132 Nov 17, 2024
3370652
minor improvements
pca006132 Nov 17, 2024
bc7d3cd
msvc changes
pca006132 Nov 17, 2024
21479c9
Merge branch 'master' of github.com:elalish/manifold into cmake-refactor
elalish Nov 17, 2024
5979b06
fix typo
elalish Nov 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 49 additions & 13 deletions .github/workflows/manifold.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ jobs:
pip install trimesh pytest
- name: Install TBB
if: matrix.parallelization == 'ON'
run: brew install tbb onedpl
run: brew install tbb
- uses: actions/checkout@v4
- uses: jwlawson/actions-setup-cmake@v2
- name: Build
Expand All @@ -232,24 +232,60 @@ jobs:
sudo cmake --install .
cd ..
./scripts/test-cmake.sh
LDFLAGS=-Wl,-rpath,/usr/local/lib ./scripts/test-pkgconfig.sh

build_nix:
build_mac_builtin_tbb:
timeout-minutes: 30
strategy:
matrix:
# variant: [none, tbb, js]
# disabling js variant for now
variant: [none, tbb]
runs-on: ubuntu-latest
runs-on: macos-latest
steps:
- name: Install common dependencies
run: |
brew install pkg-config googletest
pip install trimesh pytest
- uses: actions/checkout@v4
- uses: jwlawson/actions-setup-cmake@v2
- name: Build
run: |
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DMANIFOLD_DEBUG=ON -DMANIFOLD_PYBIND=OFF -DMANIFOLD_PAR=ON .. && make
- name: Test
run: |
cd build/test
./manifold_test
cd ../../
- name: test cmake consumer
run: |
cd build
sudo cmake --install .
cd ..
./scripts/test-cmake.sh
LDFLAGS=-Wl,-rpath,/usr/local/lib ./scripts/test-pkgconfig.sh

build_mac_builtin_tbb_subdir:
timeout-minutes: 30
runs-on: macos-latest
steps:
- name: Install common dependencies
run: |
brew install pkg-config googletest
pip install trimesh pytest
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v22
- run: nix build -L '.?submodules=1#manifold-${{matrix.variant}}'
- uses: jwlawson/actions-setup-cmake@v2
- name: test cmake consumer
run: |
cd ..
./manifold/scripts/test-cmake-subdir.sh

build_nix_python:
build_nix:
timeout-minutes: 30
strategy:
matrix:
variant: [manifold-none, manifold-tbb, manifold-js, manifold3d]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v22
- run: nix build -L '.?submodules=1#manifold3d'
- uses: DeterminateSystems/nix-installer-action@main
- uses: DeterminateSystems/magic-nix-cache-action@main
- run: nix build -L '.?submodules=1#${{matrix.variant}}'

Loading
Loading