-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test assemblies in parallel #1106
Conversation
This commit separates out the common test components from Elastic.Apm.Tests into a new assembly, Elastic.Apm.Tests.Utilities. This allows assemblies containing tests to be run in parallel, which is not possible when test assemblies reference another test assembly that may potentially be running at the same time.
This commit adds coverlet and JunitXml.TestLogger packages to all test projects using Directory.Build.Props. This removes the need to add them in CI scripts or to each project individually.
This commit updates linux CI scripts to run tests in the solution file. In conjunction with the xunit configuration, this allows test assemblies to run in parallel. Rename coverage.cobertura.xml files to include the directory name.
to Elastic.Apm.Docker.Tests
to Elastic.Apm.Perf.Tests for consistency
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 78.92% 79.40% +0.48%
==========================================
Files 152 160 +8
Lines 7520 6535 -985
==========================================
- Hits 5935 5189 -746
+ Misses 1585 1346 -239
Continue to review full report at Codecov.
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
jenkins run tests |
run tests |
This commit uses TestAgentComponents in tests to mitigate intermittent failures related to environment variables when running with AgentComponents.
When running tests in release configuration, don't allow a test method to be inlined, which may cause test assertions to fail.
And nodereuse:false from linux tests
This is now ready for review @gregkalapos. The benchmark test fails currently as the the host does not have the net50 SDK installed, and the log switchable test looks like a timing condition, which I'll see if I can address. |
This commit renames Elastic.Apm.Perf.Tests to Elastic.Apm.Benchmarks
This reverts commit f0363a8.
May be more than one session starting with the session prefix, so assert on the session name created in the test.
Jenkins cannot display Sourcelinked source code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR