Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 8+ compatibility issues #75

Closed
watson opened this issue Nov 17, 2017 · 2 comments
Closed

Node.js 8+ compatibility issues #75

watson opened this issue Nov 17, 2017 · 2 comments
Assignees
@watson
Labels
bug

Comments

@watson
Copy link
Contributor

watson commented Nov 17, 2017

There's an issue in the current instrumentation of Node.js 8 and above that means that some traces will not be collected.

We're working on a fix. Please subscribe to this issue to stay up to date.
@watson watson added the bug label Nov 17, 2017
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
aba49d1 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
16572d5 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
75a6d05 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
b4a704f 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
f212b7c 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 24, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
6ee9f1c 
Fixes elastic#75
@watson
Copy link
Contributor Author

watson commented Nov 24, 2017

The issue turned out to be the use of require('internal/process/next_tick').nextTick instead of process.nextTick in _http_outgoing.js which was introduced here: nodejs/node@4a7233c#diff-286202fdbdd74ede6f5f5334b6176b5c

watson added a commit to watson/apm-agent-nodejs that referenced this issue Nov 27, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
b55231e 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 13, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
9188e17 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 13, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
bf02f33 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 13, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
13fb8c8 
Fixes elastic#75
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 13, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
917b181 
Fixes elastic#75
@watson watson self-assigned this Dec 17, 2017
watson added a commit to watson/apm-agent-nodejs that referenced this issue Dec 21, 2017
@watson
refactor(*): use async_hooks for Node.js 8.1.0 and above
5ec35f3 
Fixes elastic#75
@watson
Copy link
Contributor Author

watson commented Jan 8, 2018

Fixed in v0.10.0 due to #77

@watson watson closed this as completed Jan 8, 2018
@trentm trentm mentioned this issue Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watson watson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@watson