-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(jenkins): support windows build #1393
Conversation
a37263c
to
2fc0dfd
Compare
Nice! Looking forward to seeing this land. :) Also, we can probably drop AppVeyor in this PR too. What do you think, @watson? |
Good idea @Qard - let's just remove AppVeyor in the PR as well 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than minor comment about version pinning.
Does this need to be backported to the |
I would try to backport it, if we can. Getting appveyor fully out of the pipeline in all actively maintained branches would be ideal. |
This reverts commit becd3de.
…js into feature/windows-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 All looks good 👍 Just have a small question that's probably very easy to answer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
The two CI failures can safely be ignored IMO as long as you squash-and-merge and give the resulting squashed commit a valid commit message. If you prefer to verify this beforehand, you can squash locally and force push up to your feature branch of course. |
Highlights
12
.appveyor
is not supported anymore.Iterations
Support docker in Windows.got some issues when using linux docker containers.no matching manifest for windows/amd64 in the manifest list entries
Tasks
Follow-ups
continuous-integration/appveyor/pr
.ci/.jenkins_nodejs.yml
Generate docker images in the internal docker registry to just consume them.Docker orchestration with docker-compose.Deprecated
Docker for windows is not required
See c21dc48