fix printing default config file path (#2060)

elastic · Jul 19, 2016 · 2e761cd · 2e761cd
1 parent 7bd61bf
commit 2e761cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/libbeat/cfgfile/cfgfile.go b/libbeat/cfgfile/cfgfile.go
@@ -14,7 +14,7 @@ var (
 	// The default config cannot include the beat name as it is not initialized
 	// when this variable is created. See ChangeDefaultCfgfileFlag which should
 	// be called prior to flags.Parse().
-	configfiles = flagArgList("c", "beat.yml", "Configuration file")
+	configfiles = flagArgList("c", "beat.yml", "Configuration file `path`")
 	overwrites  = common.NewFlagConfig(nil, nil, "E", "Configuration overwrite")
 	testConfig  = flag.Bool("configtest", false, "Test configuration and exit.")
 

diff --git a/libbeat/cfgfile/flags.go b/libbeat/cfgfile/flags.go
@@ -8,6 +8,7 @@ import (
 type argList struct {
 	list      []string
 	isDefault bool
+	f         *flag.Flag
 }
 
 func flagArgList(name string, def string, usage string) *argList {
@@ -16,10 +17,15 @@ func flagArgList(name string, def string, usage string) *argList {
 		isDefault: true,
 	}
 	flag.Var(l, name, usage)
+	l.f = flag.Lookup(name)
+	if l.f == nil {
+		panic("Failed to lookup registered flag")
+	}
 	return l
 }
 
 func (l *argList) SetDefault(v string) {
+	l.f.DefValue = v
 	l.list = []string{v}
 	l.isDefault = true
 }