Update redis client #1353
Merged
Update redis client #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite redis client based on outputs.mode package - support for TLS - support for SOCKS5 - error handling and retry logic + support for 'Guaranteed' output - support for failover and loadbalancing if multiple hosts are configured - support for multiple workers (loadbalancing mode) per redis host - backoff strategy is redis is unresponsive - split topology handling from outputer (dedicated config options in redis module) - Fix response handling draining complete response buffer after sending batch
urso
added
enhancement
in progress
|
|
||
| ===== port | ||
|
|
||
| The port of the Redis server. | ||
| Redis default port if hosts do not contain port number. The default is 6379. |
There was a problem hiding this comment.
... do not contain the port number ...
|
@dedemorton Can you have a look at the doc changes? |
| return nil, err | ||
| } | ||
|
|
||
| multiValue := major > 2 || (major == 2 && minor >= 4) |
There was a problem hiding this comment.
A note would be nice why this differentiation is needed.
|
LGTM. Would be good if perhaps @andrewkroh also could have a look. |
|
@urso Can you squash the commits? |
|
Nice job. The code LGTM. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite redis client based on outputs.mode package