Add condition to filters #1395
Add condition to filters #1395
Conversation
monicasarbu
force-pushed
the
add_condition_to_filters
branch
from
85276b1 to
a670f83
Compare
monicasarbu
changed the title
monicasarbu
added
review
and removed
in progress
monicasarbu
changed the title
|
|
||
| switch value.(type) { | ||
| case int, int8, int16, int32, int64: | ||
| int_value := reflect.ValueOf(value).Int() |
There was a problem hiding this comment.
@urso Thanks! I already changed it with reflect. Please let me know if you find any other issues.
|
Should we also update the libbeat.yml file with these options to have at least 1 example per "type" in there? |
| type EqualsValue struct { | ||
| Int int | ||
| Str string | ||
| } |
There was a problem hiding this comment.
It's kind of confusing that this one is defined here, but the RangeValue is in config.go. I'd say move one of them near the other.
The conditions can: - check if the field is equal with a string or integer (equals) - check if the field contains a given string (contains) - check if the field matches a given regular expression (regexp) - check if the field is in a given range and the supported values can be integer or float (range)
monicasarbu
force-pushed
the
add_condition_to_filters
branch
from
b5d455b to
cba9786
Compare
|
I resolved all the comments. It's ready for the final review. |
|
|
||
| for field, value := range equals { | ||
|
|
||
| i, err := strconv.Atoi(value) |
There was a problem hiding this comment.
As far as I understand, the current implementation for equal supports strings and int. In case someone wants to use float it will return an error.
There was a problem hiding this comment.
Yes, that's right. For float values, there is range.
|
Do you plan to update the libbeat.yml in this PR? Would be good to have in a later PR some system tests inside the specific beats to valide this implementation. For example having filters on the global and module level in metricbeat and see if all works as expected. |
|
The current implementation doesn't work in case the filtering rule contains a field containing a ".". I am planning to open a different PR for that. |
|
Yes, this is just the initial PR. More small PRs will follow to this one once this is merged. |
|
@monicasarbu Merged. It would be nice to have some method docs in the source code to clarify the questions we discussed above. |
This implements a task from the meta issue: #1447
This PR adds
equals,contains,regexpandrangeconditions.Please note that in the current implementation you cannot pass fields that contain
.. The fix will come in a different PR.