Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5] [libbeat] Temporarily vendor sarama from elastic's fork #14729

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

faec
Copy link
Contributor

@faec faec commented Nov 24, 2019

Vendor http://github.com/Shopify/sarama from elastic's fork which includes the Azure fix elastic/sarama@355d120

This was created by:

govendor remove github.com/Shopify/sarama
govendor fetch github.com/Shopify/sarama/^::github.com/elastic/[email protected]

To avoid regressions given release prep time constraints, this was vendored with the fix applied against Sarama 1.23.1 (the previously vendored version) rather than 1.24.1 like the master branch (#14716)

@faec faec requested a review from jsoriano November 24, 2019 15:48
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating notice, waiting for green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants