Multiline reader normalizing multiline character #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
force-pushed
the
enh/linereader-newline
branch
from
8598d3b to
1b228cf
Compare
|
@urso Was this a specific bug we had? Worth a system test? Seems to need rebase. |
|
@ruflin no specific bug. It's preparing for using regexp.Compile instead of regexp.CompilePOSIX in general. When doing the switch the |
urso
force-pushed
the
enh/linereader-newline
branch
from
1b228cf to
bbf3db2
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiline reader assumes newline characters already removed. The StripNewLine reader will be applied right before the multiline reader.