Refactor state to extrac from prospector #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, retest it |
|
|
||
| index, oldState := s.FindPrevious(newState) | ||
|
|
||
| // Only block after FindPrevious as FindPrevious has its own lock |
There was a problem hiding this comment.
is there a chance for a race between FindPrevious and actual body updating the state?
There was a problem hiding this comment.
Do you mean if it could happen that after FindPrevious an other method gets the lock and updates the state? Potentially yes I would say, but not 100% sure about the affect. I think what would happen is that a newer state could be overwritten by an older one. This would have an affect until a new state comes in which then brings it up-to-date again. So in between it could happen, that an older state exists.
There was a problem hiding this comment.
I pushed a new version with a public and private FindPrevious method. Only the public applies the lock ...
This allows the States struct to be reused also in the registrar which reduces complexity of registrar and prospector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the States struct to be reused also in the registrar which reduces complexity of registrar and prospector.