Combine separate es bulk api implementations #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now (*Connection).Bulk and (*Client).PublishEvents seem to be based on different implementations for dealing with bulk API. Only the former being tested by unit and integration tests. This refactoring removes duplicate logic.
urso
force-pushed
the
refactor/es-out-bulk
branch
from
7d219d1 to
d34380e
Compare
|
Some of the bulk tests do not seem to like these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now (_Connection).Bulk and (_Client).PublishEvents seem to be based on
different implementations for dealing with bulk API. Only the former being
tested by unit and integration tests. This refactoring removes duplicate logic.