Introduction of close_older #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,8 @@ import ( | |||
| // Defaults for config variables which are not set | |||
| const ( | |||
| DefaultRegistryFile = ".filebeat" | |||
| DefaultIgnoreOlderDuration time.Duration = 24 * time.Hour | |||
| DefaultIgnoreOlderDuration time.Duration = 72 * time.Hour | |||
There was a problem hiding this comment.
@urso I suggest to change the default to inifinite (which would be 0). WDYT? Including also @guyboertje (see https://github.com/logstash-plugins/logstash-input-file/pull/87/files#r49697378)
ruflin
force-pushed
the
close_older
branch
2 times, most recently
from
68886de to
f186aa8
Compare
| // This ensures we don't skip genuine creations with dead times less than 10s | ||
| if h.Stat.Fileinfo.ModTime().Before(p.lastscan) && | ||
| // If ignore_older is disable (by beeing 0) this never gets true | ||
| if h.Stat.Fileinfo.ModTime().Before(p.lastscan) && p.config.IgnoreOlderDuration != 0 && | ||
| time.Since(h.Stat.Fileinfo.ModTime()) > p.config.IgnoreOlderDuration { | ||
|
|
There was a problem hiding this comment.
I move it into a separate function. Still more cleanup needed (later ...)
|
LGTM |
| @@ -21,6 +21,7 @@ https://github.com/elastic/beats/compare/1.0.0...master[Check the HEAD diff] | |||
| - Rename proc.cpu.user_p with proc.cpu.total_p as includes CPU time spent in kernel space {pull}631[631] | |||
|
|
|||
| *Filebeat* | |||
| - Default config for ignore_older is now inifit instead of 24h, means ignore_older is disabled by default. Use close_older to only close file handlers. | |||
|
LGTM apart from the small comments above. |
…ssues/181 * Set close_older to 1h by defautl * Set ignore_older to infinity by default (means it is disabled by default)
This was referenced Feb 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/elastic/filebeat/issues/181