harden pgsql parser #825
Merged
harden pgsql parser #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fix off-by one error in comparison leading up to panic when accessing buffer |
|
LGTM |
| logp.Critical("Pgsql invalid parser state") | ||
| } | ||
|
|
||
| detailedf("parseMessage return: ok=%v, complete=%v, off=%v", |
There was a problem hiding this comment.
Did you intend for parseMessage to be pgsqlMessageParser?
There was a problem hiding this comment.
actually no. it was for wrapping the switch statements, but I see what you mean. Will update the output.
|
LGTM |
added 2 commits
January 25, 2016 19:14
Split parser loop in more fine-grained parser functions
- Harden pgsql parser - check pgsql strings really end with \0 - check pgsql message type - limit data row/column/fields parsing buffer regarding to length field - check row/column/fields parser consumed exactly `length` bytes - do not skip some parsing errors, but report to kill stream
urso
force-pushed
the
bug/565-pgsql-parser
branch
from
4ef40c4 to
b5e25ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #565
lengthbytes