Add tests for close_older in case of file rotation and removal #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
close_older-test
branch
from
46e80f0 to
3c8796e
Compare
| @@ -283,6 +283,27 @@ def log_contains(self, msg, logfile=None): | |||
| except IOError: | |||
| return False | |||
|
|
|||
| def log_contains_count(self, msg, logfile=None): | |||
There was a problem hiding this comment.
Since this duplicates most of log_contains(), I think log_contains() could just call this method and return log_contains_count(...) > 0.
There was a problem hiding this comment.
The reason I didn't implement it this way is that log_contains can exit much faster then count. So in case we have a large log file it is much more efficient. We discussed in the past doing some tests with large log files, which we don't have yet. So this is probably a premature optimization. Will change it.
Simplify log_contains
ruflin
force-pushed
the
close_older-test
branch
from
4a70456 to
9768444
Compare
urso
pushed a commit
that referenced
this pull request
Feb 29, 2016
Add tests for close_older in case of file rotation and removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.