Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the 'Snapshot and restore' section #480

Merged
merged 26 commits into from
Feb 21, 2025
Merged

Updating the 'Snapshot and restore' section #480

merged 26 commits into from
Feb 21, 2025

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Feb 18, 2025

This PR updates the whole Snapshot and restore section.
The PR also includes refinements in the Cross-cluster replication section (but it is not completely ready yet).

Main changes

Restructured the Manage snapshot repositories section
Added or refined the following pages:

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks really great!

Added a few comments, if some of them feel out of the scope of the PR feel free to ignore them or create separate issues for the future (if you consider they are worthy).

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this looks like a huge amount of work! great job.

agree w/ all of edu's comments. one thing I'd add is that all of the mapping notes on the pages you merged need to be removed (i.e. the % and $ lines)

unfortunately, the syntax for applies has changed, so this PR won't pass CI after you fix the new conflicts. hopefully cleaning them up is not too much work.

@kosabogi kosabogi requested a review from eedugon February 21, 2025 07:22
@kosabogi kosabogi requested a review from eedugon February 21, 2025 10:53
eedugon
eedugon previously approved these changes Feb 21, 2025
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just final comments!

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eedugon eedugon merged commit 204f23c into main Feb 21, 2025
4 checks passed
@eedugon eedugon deleted the refinements branch February 21, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants