-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the 'Snapshot and restore' section #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks really great!
Added a few comments, if some of them feel out of the scope of the PR feel free to ignore them or create separate issues for the future (if you consider they are worthy).
deploy-manage/tools/snapshot-and-restore/elastic-cloud-hosted.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/elastic-cloud-hosted.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/access-isolation-for-found-snapshots-repository.md
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/repository-isolation-on-azure.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/repository-isolation-on-aws-gcp.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/access-isolation-for-found-snapshots-repository.md
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/access-isolation-for-found-snapshots-repository.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, this looks like a huge amount of work! great job.
agree w/ all of edu's comments. one thing I'd add is that all of the mapping notes on the pages you merged need to be removed (i.e. the % and $ lines)
unfortunately, the syntax for applies
has changed, so this PR won't pass CI after you fix the new conflicts. hopefully cleaning them up is not too much work.
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
…usters.md Co-authored-by: Edu González de la Herrán <[email protected]>
…on-azure.md Co-authored-by: Edu González de la Herrán <[email protected]>
…on-aws-gcp.md Co-authored-by: Edu González de la Herrán <[email protected]>
…found-snapshots-repository.md Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
deploy-manage/tools/snapshot-and-restore/manage-snapshot-repositories.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just final comments!
deploy-manage/tools/snapshot-and-restore/ece-aws-custom-repository.md
Outdated
Show resolved
Hide resolved
…tory.md Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the whole Snapshot and restore section.
The PR also includes refinements in the Cross-cluster replication section (but it is not completely ready yet).
Main changes
Restructured the Manage snapshot repositories section
Added or refined the following pages: