Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid negative sizes in Search slice #1360

Merged
merged 2 commits into from
May 5, 2020
Merged

Avoid negative sizes in Search slice #1360

merged 2 commits into from
May 5, 2020

Conversation

bk-equityzen
Copy link
Contributor

Resolves #1358

@cla-checker-service
Copy link

cla-checker-service bot commented May 5, 2020 •
edited
Loading

💚 CLA has been signed

@bk-equityzen bk-equityzen mentioned this pull request May 5, 2020
Closed
sethmlarson
sethmlarson suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much! One tiny comment.

elasticsearch_dsl/search.py Outdated Show resolved Hide resolved
@bk-equityzen bk-equityzen requested a review from sethmlarson May 5, 2020 21:40
sethmlarson
sethmlarson approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sethmlarson sethmlarson merged commit 5063955 into elastic:master May 5, 2020
@sethmlarson sethmlarson mentioned this pull request Jun 2, 2020
Merged
@renovate renovate bot mentioned this pull request Jul 15, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverse slices result in negative size
2 participants
@bk-equityzen @sethmlarson