-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the "boxplot" aggregation #1412
Conversation
This commit adds a new Agg subclass called BoxPlot, which passes the name "boxplot" as the aggregation type. See https://www.elastic.co/guide/en/elasticsearch/reference/7.x/search-aggregations-metrics-boxplot-aggregation.html#_syntax
💚 CLA has been signed |
For some reason the cla-checker-service hasn't picked up my CLA, so I'm pushing a new commit in the hope that it triggers the check again.
Black has updated some rules around how trailing commas are dealt with in wrapping of lists.
CI is failing on Black linting - I haven't edited any of the files that are failing, but there has been an update to Black since the last successful build, which may explain it. |
Confirmed - have re-run Black using the latest version. |
The standard token filter was a noop in 6.x and has been removed in 7.x
I have also removed the "standard" token filter from the |
Fixed isses in
|
It's curently failing because of a dependency issue in coverage that has nothing to do with this project.
I have allowed the "nightly" python build to fail on Travis. |
@hugorodgerbrown Thanks for these changes. Could you add the changes to CI / tests to their own PR and keep this only BoxPlot agg so I can backport automatically? :) |
Closing this in favor of #1416 |
This commit adds a new Agg subclass called BoxPlot, which passes the name "boxplot" as the aggregation type.
See https://www.elastic.co/guide/en/elasticsearch/reference/7.x/search-aggregations-metrics-boxplot-aggregation.html#_syntax
Fixes #1411