Add year interval for DateHistogramFacet #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to make this merged? |
sethmlarson
suggested changes
Jul 7, 2021
elasticsearch_dsl/faceted_search.py
Outdated
| @@ -168,6 +168,10 @@ def get_value_filter(self, filter_value): | |||
| ) | |||
|
|
|||
|
|
|||
| def _date_interval_year(d): | |||
| return (d + timedelta(days=366)).replace(day=1) | |||
There was a problem hiding this comment.
Let's change this to return d.replace(year=d.year+1, day=(28 if d.month == 2 and d.day == 29 else d.day)) since years are linear unlike months.
We should add a test case for leap day handling as well (Basically see that February 29th, 2020 increments to February 28th, 2021)
There was a problem hiding this comment.
Done. Updated to return d.replace(year=d.year+1, day=(28 if d.month == 2 and d.day == 29 else d.day))
|
Thank you |
This was referenced Jul 15, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
yearinterval for DateHistogramFacet.Closes #1501