Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 Deprecations in ClientBuilder #1413

Closed
TimWolla opened this issue Sep 13, 2024 · 1 comment · Fixed by #1415
Closed

PHP 8.4 Deprecations in ClientBuilder #1413

TimWolla opened this issue Sep 13, 2024 · 1 comment · Fixed by #1415

Comments

@TimWolla
Copy link

Using elasticsearch-php in PHP 8.4 emits 3 deprecation notices when loading ClientBuilder, due to the https://wiki.php.net/rfc/deprecate-implicitly-nullable-types RFC:

Deprecated: Elastic\Elasticsearch\ClientBuilder::setApiKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 229

Deprecated: Elastic\Elasticsearch\ClientBuilder::setSSLCert(): Implicitly marking parameter $password as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 275

Deprecated: Elastic\Elasticsearch\ClientBuilder::setSSLKey(): Implicitly marking parameter $password as nullable is deprecated, the explicit nullable type must be used instead in src/ClientBuilder.php on line 298

As far as I can tell there are no other issues with elasticsearch-php itself when running the test suite using PHP 8.4. Only the php-http/mock-client dependency reports a similar deprecation.
ruudk added a commit to ruudk/elasticsearch-php that referenced this issue Oct 31, 2024
@ruudk
Make compatible with PHP 8.4
4a362b4 
Fixes elastic#1413
@ruudk ruudk mentioned this issue Oct 31, 2024
Merged
@ruudk
Copy link
Contributor

ruudk commented Oct 31, 2024

See #1415

ezimuel pushed a commit that referenced this issue Nov 4, 2024
@ruudk
PHP 8.4 compatibility (#1415)
7440931 
* Add PHP 8.4 to matrix

* Make compatible with PHP 8.4

Fixes #1413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 8.4 compatibility ruudk/elasticsearch-php
2 participants
@ruudk @TimWolla