Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fine-tunes breaking changes and community DSLs pages in PHP client book #1025

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 30, 2020

Overview

This PR fine-tunes the wording of the following sections and improves readability.

Preview

Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szabosteve for your PR. All seems to be good. I only added a note, in the E_USER_DEPREACATED section in breaking-changes.asciidoc. Let me know if you can add this in the docs. Thanks!

https://www.php.net/manual/en/errorfunc.constants.php[E_USER_DEPRECATED] notice
every time you use a deprecated parameters for {es}. We decided to add this
notice to facilitate the code refactoring with the new API specification of {es}
(for example the usage of typeless APIs, see below).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention here that we silent the E_USER_DEPRECATED warning in 7.4.1 (using the @ operator) due to BC break issues in other libraries using elasticsearch-php. The full story can be found here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezimuel
Thank you for the review and for the note. I added the story to the E_USER_DEPRECATED section in e8d582d. Please let me know if you want to change/add anything.

@ezimuel ezimuel merged commit 359aa98 into elastic:7.x Jun 10, 2020
@szabosteve szabosteve deleted the 7.x.docs.rev.bc.cdsl branch June 10, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants