-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output json_last_error_msg instead of json_last_error #1045
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
I signed the CLA now. How can I trigger the CLA checker service again? |
@jkrzefski thanks for this PR. I checked and the CLA is ok. I'm checking about the Travis CI failing. The PR seems good to me. |
@jkrzefski I see the issue. You need to send the PR against 7.x and not master. I suggest to rebase from I just added a Contributing section about that in the README. |
@ezimuel I rebased my changes and changed the target branch. Will I have to file a new pull request or is this also ok? |
@jkrzefski thanks everything is ok now. |
The
JsonErrorException
already converts the error code fromjson_last_error
into a human readable error message. TheRuntimeException
however does not do this. To have more consistency between the two and for improved human readability I have changedjson_last_error
tojson_last_error_msg
. Error messages now no longer look like this:And instead they look more like this: